OEL-779: Review patterns: Accordion, Alert, Badge, Banner, Blockquote and Breadcrumbs #150
Conversation
escuriola
force-pushed
the
OEL-779-part-one
branch
3 times, most recently
from
6a8ad61
to
4407525
Compare
escuriola
changed the title
escuriola
force-pushed
the
OEL-779-part-one
branch
from
658d0e8
to
e293066
Compare
| type: boolean | ||
| label: "Flush" | ||
| description: "set Flush to remove the default background-color, some borders, and some rounded corners to render accordions edge-to-edge with their parent container." | ||
| label: 'Flush' |
There was a problem hiding this comment.
Change flush to "bare layout"
escuriola
force-pushed
the
OEL-779-part-one
branch
from
cea2d28
to
91f675a
Compare
| light: 'light' | ||
| dark: 'dark' | ||
| link: 'link' | ||
| preview: 'primary' |
There was a problem hiding this comment.
Default value is not necessary to be added here.
| preview: True | ||
| label: 'Dismissible' | ||
| description: 'Add close button to dismiss the alert inline. Enabled by default.' | ||
| preview: true |
There was a problem hiding this comment.
Dismissible default value is not necessary to report it here.
| preview: True | ||
| label: 'Animated dismiss' | ||
| description: 'Add fade animation to the dismissible alert. Enabled by default.' | ||
| preview: true |
There was a problem hiding this comment.
Same, is not necessary, eliminate it at markup rendering test if present.
| light: 'light' | ||
| dark: 'dark' | ||
| link: 'link' | ||
| preview: 'primary' |
There was a problem hiding this comment.
Is not necessary to put the default. Can be deleted at markup test if present.
| description: "Enable the shadow effect to the image." | ||
| type: boolean | ||
| label: 'Shade' | ||
| description: 'Enable the shadow effect to the image. False by default.' | ||
| preview: false |
There was a problem hiding this comment.
Not necessary. Can be deleted. Check if present at markup test.
| description: "Display banner as hero banner" | ||
| type: boolean | ||
| label: 'Hero' | ||
| description: 'Display as hero banner. False by default.' | ||
| preview: false |
There was a problem hiding this comment.
Not necessary. Can be deleted. Check if present at markup test.
| description: "Possibility of having a full-width banner within a bootstrap container" | ||
| type: boolean | ||
| label: 'Full width' | ||
| description: 'Possibility of having a full-width banner within a bootstrap container. False by default.' | ||
| preview: false |
There was a problem hiding this comment.
Not necessary. Can be deleted. Check if present at markup test.
| icon: | ||
| name: "chevron-right" | ||
| name: 'chevron-right' | ||
| size: s |
There was a problem hiding this comment.
Not necessary, 's' is the default size. Can be deleted. Leave the assertion for icon having size 's'.
| left: 'left' | ||
| center: 'center' | ||
| end: 'end' | ||
| preview: 'left' |
There was a problem hiding this comment.
Not necessary. Eliminate the setting of this at markup tests.
| label: Alert | ||
| description: Provide contextual feedback messages for typical user actions with the handful of available and flexible alert messages. https://v5.getbootstrap.com/docs/5.0/components/alerts/ | ||
| label: 'Alert' | ||
| description: 'Provide contextual feedback messages for typical user actions with the handful of available and flexible alert messages. https://v5.getbootstrap.com/docs/5.0/components/alerts/' | ||
| settings: | ||
| style: |
There was a problem hiding this comment.
Why we don't use variants for this? I think it fits more the scope of variants.
There was a problem hiding this comment.
Variant is a reserved word and doesn't work if there are no variants (patterns with different behaviours) in the pattern.
| preview: "/assets/icons/bootstrap-icons.svg" | ||
| label: 'Message' | ||
| description: 'The alert message.' | ||
| preview: 'A simple alert—check it out!' | ||
| icon_name: |
There was a problem hiding this comment.
Should we simplify this and use "icon:" ?
| type: text | ||
| label: 'Description' | ||
| description: 'Sub-heading of the banner.' | ||
| preview: 'Innovation, economy, environment and geopolitics' | ||
| link: |
There was a problem hiding this comment.
Should we maybe rename this, since it's not just a link?
| @@ -1,11 +1,11 @@ | |||
| accordion: | |||
| accordion_with_flush: | |||
There was a problem hiding this comment.
Maybe accordion_with_bare_layout?
escuriola
force-pushed
the
OEL-779-part-one
branch
from
2412092
to
a3d862c
Compare
escuriola
force-pushed
the
OEL-779-part-one
branch
from
a3d862c
to
bb2d16e
Compare
Jira issue(s):
Added quote paragraph testing.