Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic OEL-779: review patterns #170

Merged
merged 143 commits into from
Feb 3, 2022
Merged

Epic OEL-779: review patterns #170

merged 143 commits into from
Feb 3, 2022

Conversation

brummbar
Copy link
Contributor

@brummbar brummbar commented Feb 1, 2022

No description provided.

escuriola and others added 30 commits January 21, 2022 16:41
@escuriola
OEL-779: Button remove variants and change variant to style. Modifyin…
d3ef7b8 
…g other patterns. Improve doc.
@escuriola
OEL-779: Remove spinner and other fields from button. Prepare to tran…
3232caf 
…sform button pattern naming to button patterns.
@escuriola
OEL-779: Improve button group.
f2d7698
@escuriola
OEL-779: Improve carousel.
8f8703a
@escuriola
OEL-779: Removing unused patterns.
ccfa390
@escuriola
OEL-779: Fixing button tests.
9cbf62a
@escuriola
OEL-779: For more information links doc.
ac3a6db
@escuriola
OEL-779: Button disabled default attribute value.
daf1389
@escuriola
OEL-779: Carousel remove references to caption classes.
0ab19f8
@escuriola
OEL-779: Improve documentation.
c095c02
@escuriola
OEL-779: Button remarks changes.
2b2b264
@escuriola
OEL-779: Carousel remarks changes.
7c51c40
@escuriola
OEL-779: Modal button remarks changes.
65cc894
@escuriola
OEL-779: Offcanvas button remarks changes.
391dfc6
@brummbar
OEL-779: Do not use render arrays for carousel images.
03080a4
@brummbar
OEL-779: Fix related carousel tests.
f502c14
@escuriola
OEL-779: Fix plural.
9702ae4
@brummbar
Merge pull request #152 from openeuropa/OEL-779-part-two
c176c5b 
OEL-779: Review patterns: Button, Carousel and remove several patterns.
@abel-santos-corral
OEL-779: Fix pattern date_block.
9247673
@abel-santos-corral
OEL-779: Fix pattern dropdown and add more tests.
e947a98
@abel-santos-corral
OEL-779: Fix icon pattern, twig and tests.
65f72c1
@abel-santos-corral
OEL-779: Fix jumbotron pattern, twig and tests.
a9d72fa
@abel-santos-corral
OEL-779: Eliminate jumbotron.
591dc30
@abel-santos-corral
OEL-779: Add id for dropdown at pattern.inc.
85dcb9c
@abel-santos-corral
OEL-779: Put default in the list of icon size.
e1fb4fe
@abel-santos-corral
OEL-799: Fix label at items. Add dropdown option.
d9411a9
@abel-santos-corral
OEL-779: Eliminate preview of link field.
cc557b4
@abel-santos-corral
OEL-779: Fix management of trigger.
71bc55f
@abel-santos-corral
OEL-779: Fix settings and fields of icon pattern.
17380c7
@abel-santos-corral
OEL-779: Drop field alignment.
a7abf5d
abel-santos-corral and others added 26 commits February 1, 2022 18:32
@abel-santos-corral @brummbar
OEL-779: Fix featured media twig and pattern.
993cb97
@abel-santos-corral @brummbar
OEL-779: Rename imagestyle field into image.
6940134
@abel-santos-corral @brummbar
OEL-779: Change content into fields.
42789cd
@abel-santos-corral @brummbar
OEL-779: Check if text_title is reported.
ad4a4d6
@abel-santos-corral @brummbar
OEL-779: Fix test rendering feature media.
adc7f01
@abel-santos-corral @brummbar
OEL-779: Eliminate inside_text. Fix link.
ff0c3e4
@abel-santos-corral @brummbar
OEL-779: Add control to field_oe_link. Add assertions at MediaParagra…
cfb014a 
…phsTest.
@escuriola @brummbar
OEL-779: Cleaning some fields from feature media.
2bef507
@escuriola @brummbar
OEL-779: Use ImageValueObject to featured media image.
d68e717
@brummbar
OEL-779: Reshuffle paragraph code.
03ac361
@brummbar
OEL-779: Lock allowed_formats to allow tests to pass.
d81520b
@brummbar
OEL-779: Move handling of image render array to code, remove settings…
9e9fdfd 
…, improve field names.
@brummbar
OEL-779: No need to initialise the image variable if not present.
1bff8f7
@abel-santos-corral @brummbar
OEL-779: Fix assertions of featured markup tests.
1a14876
@abel-santos-corral @brummbar
OEL-779: Eliminate unneeded quotes at featured-media tests.
78b6b64
@abel-santos-corral @brummbar
OEL-779: Eliminate preview management for featured.
5ec5021
@brummbar @abel-santos-corral
OEL-779: Remove locked dependency for allowed_formats.
1a3a3e6
@escuriola @drishu
OEL-779: Offcanvas search variant.
a32165e
@escuriola @drishu
OEL-779: Offcanvas reuse refactor adding blocks.
ac9318d
@escuriola @drishu
OEL-779: Remove extra variable.
a865801
@escuriola @drishu
OEL-779: Indentation.
25dacc5
@escuriola
OEL-779: Fix Whitelabel issues with navigation.
a16969c
@escuriola @drishu
OEL-779: Fix card layout.
91843b5
@escuriola @drishu
OEL-779: Minor refactor.
8b00f70
@escuriola @drishu
OEL-779: Fixing tests.
270142e
@drishu
OEL-779: Add background toggle to navbar.
3745a6f
@drishu drishu merged commit d3ada5b into 1.x Feb 3, 2022
@brummbar brummbar deleted the EPIC-779-review-patterns branch July 19, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escuriola escuriola escuriola approved these changes

@drishu drishu drishu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brummbar @escuriola @drishu @abel-santos-corral