OEL-1175: Image and styles added to solve required fields on forms. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
previously approved these changes
Feb 28, 2022
escuriola
suggested changes
Feb 28, 2022
assets/images/required.svg
Outdated
| @@ -0,0 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="16" height="16"><path fill="#EE0000" d="M0,7.562l1.114-3.438c2.565,0.906,4.43,1.688,5.59,2.35C6.398,3.553,6.237,1.544,6.22,0.447h3.511 c-0.05,1.597-0.234,3.6-0.558,6.003c1.664-0.838,3.566-1.613,5.714-2.325L16,7.562c-2.05,0.678-4.06,1.131-6.028,1.356 c0.984,0.856,2.372,2.381,4.166,4.575l-2.906,2.059c-0.935-1.274-2.041-3.009-3.316-5.206c-1.194,2.275-2.244,4.013-3.147,5.206 l-2.856-2.059c1.872-2.307,3.211-3.832,4.017-4.575C3.849,8.516,1.872,8.062,0,7.562"/></svg> | |||
There was a problem hiding this comment.
No internal files are stored in assets, is a folder for external files or processed/compiled. After talk with @drishu, this file should be stored at resources/images folder.
escuriola
suggested changes
Feb 28, 2022
resources/sass/components/_form.scss
Outdated
| @@ -0,0 +1,19 @@ | |||
| // form | |||
| // https://getbootstrap.com/docs/5.0/forms/overview/ | |||
There was a problem hiding this comment.
No more links to bootstrap. Remove this line
drishu
requested changes
Mar 4, 2022
escuriola
previously approved these changes
Mar 4, 2022
drishu
reviewed
Mar 7, 2022
resources/sass/components/_form.scss
Outdated
| content: ''; | ||
| vertical-align: super; | ||
| display: inline-block; | ||
| background-image: url('../../images/required.svg'); |
There was a problem hiding this comment.
are we guessing ? can you please verify before submitting.
There was a problem hiding this comment.
We did, no guessing we checked, anyway fixed again, thanks for your input.
escuriola
approved these changes
Mar 7, 2022
drishu
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):