OEL-1322: PHP 8.0 Upgrade. #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escuriola
force-pushed
the
OEL-1322
branch
5 times, most recently
from
c8cc2bc
to
e5e558f
Compare
brummbar
requested changes
Mar 18, 2022
.drone.yml
Outdated
| @@ -17,6 +17,7 @@ services: | |||
| image: registry.fpfis.eu/fpfis/httpd-php:${PHP_VERSION}-ci | |||
| environment: | |||
| - DOCUMENT_ROOT=/test/oe_bootstrap_theme | |||
| - COMPOSERVER=--2 | |||
There was a problem hiding this comment.
We removed this already recently, no need to readd.
brummbar
previously approved these changes
Mar 21, 2022
|
Seems good to me. For the changes in composer.json, we need to make sure to clean up if we no longer need these packages. E.g. token is only needed for ui_patterns_settings, and perhaps we will remove this in the future? I also don't know if there are any yet undiscovered problems for PHP 8.0. |
donquixote
previously approved these changes
Mar 22, 2022
|
Btw the README.md still talks about PHP 7.3 as a minimum version. |
donquixote
approved these changes
Mar 22, 2022
brummbar
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1322