OEL-1618: Update BCL to 0.23.0 #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donquixote
reviewed
May 31, 2022
donquixote
reviewed
May 31, 2022
templates/patterns/content_banner/pattern-content-banner.html.twig
Outdated
Show resolved
Hide resolved
donquixote
reviewed
May 31, 2022
donquixote
reviewed
May 31, 2022
templates/patterns/offcanvas/pattern-offcanvas--variant-search.html.twig
Show resolved
Hide resolved
donquixote
previously approved these changes
Jun 1, 2022
escuriola
force-pushed
the
OEL-1618
branch
2 times, most recently
from
8fa3dc9
to
1fef192
Compare
|
I think we need a follow-up for featured media paragraph + pattern. The heading in the pattern is EDIT: Actually it is ok on the "Landing page" where the paragraph is used: https://oelibrary.netlify.app/default/?path=/story/features-landing-page--default Let's fix here, no need for separate issue. |
donquixote
previously approved these changes
Jun 15, 2022
brummbar
previously approved these changes
Jun 22, 2022
…r paragraphs/patterns.
brummbar
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1618