OEL-1540: Do not load inpage_navigation pattern if there are no links to display #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
previously approved these changes
May 25, 2022
donquixote
reviewed
Jun 1, 2022
templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig
Show resolved
Hide resolved
donquixote
reviewed
Jun 3, 2022
templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig
Outdated
Show resolved
Hide resolved
donquixote
reviewed
Jun 3, 2022
tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml
Show resolved
Hide resolved
donquixote
approved these changes
Jun 3, 2022
drishu
reviewed
Jun 7, 2022
tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml
Show resolved
Hide resolved
drishu
previously approved these changes
Jun 7, 2022
donquixote
previously approved these changes
Jun 9, 2022
… is not empty instead is not null. Added test to check the content is rendered.
donquixote
approved these changes
Jun 9, 2022
donquixote
approved these changes
Jun 9, 2022
drishu
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1540