Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEL-1326: Update card listing. #250

Merged
merged 3 commits into from
Aug 4, 2022
Merged

OEL-1326: Update card listing. #250

merged 3 commits into from
Aug 4, 2022

Conversation

escuriola
Copy link
Contributor

drishu
drishu previously approved these changes Jul 11, 2022
donquixote
donquixote previously approved these changes Jul 18, 2022
@drishu drishu dismissed stale reviews from donquixote and themself via 0e5733c July 29, 2022 08:51
drishu
drishu previously approved these changes Jul 29, 2022
@drishu drishu changed the title OEL-1326: Cleaning patterns & paragraphs from OEL-755 OEL-1326: Update card listing. Jul 29, 2022
donquixote
donquixote previously approved these changes Jul 29, 2022
@brummbar brummbar dismissed stale reviews from donquixote and drishu via 54a7cc8 August 4, 2022 15:41
drishu
drishu previously approved these changes Aug 4, 2022
escuriola and others added 3 commits August 4, 2022 17:48
If a scalar is passed, invoking a method on it will throw an error. We expect
it to be a Url object, so we just need to check it's an instance of that type.
@brummbar brummbar merged commit 86c3568 into 1.x Aug 4, 2022
@brummbar brummbar deleted the OEL-1326 branch August 4, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants