OEL-1823: BCL 0.24.0 #253
Merged
OEL-1823: BCL 0.24.0 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
requested changes
Jul 13, 2022
tests/src/Kernel/fixtures/markup_rendering_patterns/inpage_navigation.yml
Outdated
Show resolved
Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/offcanvas.yml
Outdated
Show resolved
Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/offcanvas.yml
Outdated
Show resolved
Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/offcanvas.yml
Outdated
Show resolved
Hide resolved
tests/src/Kernel/fixtures/markup_rendering_patterns/offcanvas.yml
Outdated
Show resolved
Hide resolved
| * Asserts elements that are common for file and translation sections. | ||
| * | ||
| * @param string $data_container_selector | ||
| * Crawler object with the item data. |
There was a problem hiding this comment.
if it's string it can't be a "Crawler object"
templates/patterns/inpage_navigation/pattern-inpage-navigation.html.twig
Show resolved
Hide resolved
drishu
requested changes
Jul 14, 2022
drishu
previously approved these changes
Jul 14, 2022
drishu
previously approved these changes
Jul 29, 2022
brummbar
force-pushed
the
OEL-1823
branch
2 times, most recently
from
2add645
to
7afe27d
Compare
drishu
previously approved these changes
Aug 4, 2022
drishu
approved these changes
Aug 4, 2022
brummbar
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):
https://citnet.tech.ec.europa.eu/CITnet/jira/browse/OEL-1823