OEL-1912: Revamp carousel pattern. #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
commented
Aug 19, 2022
| label: 'Show indicators' | ||
| description: 'With indicators (default: false).' | ||
| preview: true | ||
| autoplay: |
There was a problem hiding this comment.
I feel we could keep this one, what do you think ?
drishu
commented
Aug 19, 2022
| 'items': _slides, | ||
| 'fade': fade, | ||
| 'with_controls': show_controls, | ||
| 'with_controls': true, |
There was a problem hiding this comment.
I know there are defaults, but want to set in stone the behaviour
brummbar
requested changes
Aug 23, 2022
| @@ -1,54 +1,19 @@ | |||
| carousel: | |||
| label: 'Carousel' | |||
| description: 'A slideshow component for cycling through elements, like a carousel. For more information: https://v5.getbootstrap.com/docs/5.0/components/carousel/' | |||
| settings: | |||
There was a problem hiding this comment.
Unfortunately we shipped with these field already, so we cannot remove them anymore. I didn't realise for some reason that we had already a pattern when I did the analysis. We need to leave it untouched in this version.
| */ | ||
| protected function assertItems(array $expected, Crawler $crawler): void { | ||
| $items = $crawler->filter('.carousel .carousel-inner .carousel-item'); | ||
| self::assertCount(count($expected), $items); |
There was a problem hiding this comment.
Suggested change
| self::assertCount(count($expected), $items); | |
| self::assertSameSize($expected, $items); |
drishu
commented
Aug 25, 2022
brummbar
requested changes
Aug 29, 2022
| } | ||
|
|
||
| if (!empty($expected['show_controls'])) { | ||
| $this->assertElementText('Previous', '.carousel-control-prev', $crawler); |
There was a problem hiding this comment.
Most of these methods can receive NULL and they will check for absence of element/attribute.
We could rewrite (some of) them like this:
Suggested change
| $this->assertElementText('Previous', '.carousel-control-prev', $crawler); | |
| $this->assertElementText($expected['show_controls'] ?? NULL, '.carousel-control-prev', $crawler); |
brummbar
previously approved these changes
Aug 31, 2022
brummbar
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.