OEL-2166: Upgrade to BCL 1.0.0 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummbar
force-pushed
the
OEL-1995
branch
2 times, most recently
from
5081ccd
to
da96cc4
Compare
brummbar
changed the title
drishu
requested changes
Oct 6, 2022
kits/default/package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "production": "npm-run-all build:*" | |||
| }, | |||
| "devDependencies": { | |||
| "@openeuropa/bcl-builder": "0.24.1", | |||
| "@openeuropa/bcl-builder": "0.25.1", | |||
docker-compose.yml
Outdated
| @@ -28,7 +28,7 @@ services: | |||
| user: "node" | |||
| working_dir: /home/node/app | |||
| environment: | |||
| - NODE_ENV=${NODE_ENV} | |||
| - NODE_ENV=${NODE_ENV:-''} | |||
There was a problem hiding this comment.
Can you give me a bit on info, the commit message should also be a bit more descriptive.
:- evaluates to use '' if NODE_ENV is unset or empty, but we give an empty string as default, would - (use '' if NODE_ENV is unset) work ?
There was a problem hiding this comment.
We'll replace with - only as it's the same operation done by Docker: provides an empty string as fallback only when the variable is not defined at all.
|
Fixed the offcanvas, for which I reviewed the updates back in the days but forgot to bring them. The inpage navigation is broken so I'll create an issue for it. |
…ate search variant.
Bootstrap 5.2 has bugs in the scrollspy script. One of the needed fixes is to not target the body element but an inner wrapper as element to track. Unfortunately this doesn't seem to be enough either.
drishu
changed the title
drishu
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.