Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-2254: Fixed path of bootstrap-ie11.css #310

Merged
merged 1 commit into from
Mar 9, 2023
Merged

OEL-2254: Fixed path of bootstrap-ie11.css #310

merged 1 commit into from
Mar 9, 2023

Conversation

tibi2303
Copy link
Contributor

@tibi2303 tibi2303 commented Mar 6, 2023

Jira issue(s):

@tibi2303 tibi2303 linked an issue Mar 6, 2023 that may be closed by this pull request
The bootstrap-ie11.css is included from the active theme #202
Closed
drishu
drishu previously approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need access checks and we know the file is present, so its ok for me. I also don't think this needs a test.

@drishu drishu changed the title OEL-2254: Changed path of bootstrap-ie11.css OEL-2254: Fixed path of bootstrap-ie11.css Mar 9, 2023
@drishu drishu merged commit be5b1b5 into 1.x Mar 9, 2023
@drishu drishu deleted the OEL-2254 branch March 9, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drishu drishu drishu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The bootstrap-ie11.css is included from the active theme
2 participants
@tibi2303 @drishu