OEL-2266: Added image on mobile and fixed spacing in card search. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 23, 2023
drishu
reviewed
May 17, 2023
drishu
force-pushed
the
OEL-2266
branch
4 times, most recently
from
a5256f9
to
996a59e
Compare
brummbar
reviewed
Jul 10, 2023
includes/pattern.inc
Outdated
| * Implements hook_preprocess_HOOK() for gallery pattern. | ||
| */ | ||
| function oe_bootstrap_theme_preprocess_pattern_card(array &$variables): void { | ||
| $variables['oebt_bc_card_search_image_not_visible_on_mobile'] = theme_get_setting('oebt_bc.card_search_image_not_visible_on_mobile') ?? TRUE; |
There was a problem hiding this comment.
What about?
Suggested change
| $variables['oebt_bc_card_search_image_not_visible_on_mobile'] = theme_get_setting('oebt_bc.card_search_image_not_visible_on_mobile') ?? TRUE; | |
| $variables['oebt_bc_card_search_image_hidden_on_mobile'] = theme_get_setting('oebt_bc.card_search_image_hidden_on_mobile') ?? TRUE; |
drishu
reviewed
Jul 11, 2023
| @@ -12,3 +12,13 @@ oe_bootstrap_theme.settings: | |||
| responsive: | |||
| type: string | |||
| label: 'Responsive tables' | |||
| backward_compatibility: | |||
| type: mapping | |||
| label: 'OEL Improvements' | |||
There was a problem hiding this comment.
Not important but I forgot to update this label
drishu
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s):