Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRONT-2441: Accordion Pattern. #41

Merged
merged 2 commits into from
Sep 7, 2021
Merged

FRONT-2441: Accordion Pattern. #41

merged 2 commits into from
Sep 7, 2021

Conversation

tibi2303
Copy link
Contributor

@tibi2303 tibi2303 commented Aug 12, 2021 •
edited
Loading

No description provided.

@abel-santos-corral abel-santos-corral linked an issue Aug 25, 2021 that may be closed by this pull request
Refactor Accordion pattern with BCL component #11
Closed
drishu
drishu requested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to change includes/paragraphs.incL37 from body to content. The item content is not showing.

Maxfire
Maxfire previously approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@Maxfire Maxfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and approved.

Maxfire
Maxfire approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@Maxfire Maxfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@drishu drishu merged commit 10ed762 into 1.x Sep 7, 2021
@drishu drishu deleted the FRONT-2441 branch September 7, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maxfire Maxfire Maxfire approved these changes

@drishu drishu drishu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Accordion pattern with BCL component
3 participants
@tibi2303 @Maxfire @drishu