Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRONT-2432: Blockquote Pattern. #43

Merged
merged 3 commits into from
Sep 3, 2021
Merged

FRONT-2432: Blockquote Pattern. #43

merged 3 commits into from
Sep 3, 2021

Conversation

tibi2303
Copy link
Contributor

No description provided.

@abel-santos-corral abel-santos-corral linked an issue Aug 25, 2021 that may be closed by this pull request
Refactor blockquote pattern with BCL component #8
Closed
drishu
drishu requested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need to update templates/paragraphs/paragraph--oe-quote.html.twig to send parameters quote, attribution, cite and alignement

templates/patterns/blockquote/pattern-blockquote.html.twig Outdated
'attribution': attribution,
'cite': cite,
'alignment': alignment
} %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline

Maxfire
Maxfire previously approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@Maxfire Maxfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and working nicely. Greetings.

@cmarcmar
Copy link

cmarcmar commented Sep 3, 2021

Looks good, working as expected.

@cmarcmar cmarcmar self-requested a review September 3, 2021 09:57
@drishu drishu merged commit aa387a2 into 1.x Sep 3, 2021
@drishu drishu deleted the FRONT-2432 branch September 3, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drishu drishu drishu approved these changes

@cmarcmar cmarcmar cmarcmar approved these changes

@Maxfire Maxfire Maxfire left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor blockquote pattern with BCL component
5 participants
@tibi2303 @cmarcmar @Maxfire @drishu @escuriola