FRONT-2449: Button Pattern.

[tibi2303]

No description provided.

[drishu]

see todo in templates/overrides/form/input--submit.html.twig
this needs to be implemented.
Take notice of button attributes (primary secondary) and change according to the pattern variants.

Please add - "bcl" under file_scan_ignore_directories in runner.dist.yml until #61 is solved.

[escuriola]

see todo in templates/overrides/form/input--submit.html.twig
this needs to be implemented.
Take notice of button attributes (primary secondary) and change according to the pattern variants.

Please add - "bcl" under file_scan_ignore_directories in runner.dist.yml until #61 is solved.

This would print a button which by itself that not submit the form.

[drishu]

see todo in templates/overrides/form/input--submit.html.twig
this needs to be implemented.
Take notice of button attributes (primary secondary) and change according to the pattern variants.
Please add - "bcl" under file_scan_ignore_directories in runner.dist.yml until #61 is solved.

This would print a button which by itself that not submit the form.

I think that if the button is of type submit then its fine, please test

[drishu]

I think for this task we should theme button elements also, I looked into it, to do this we can't override a template, but we can theme from scss
in _all.scss add

button.link {
  display: inline;
  margin: 0;
  padding: 0;
  cursor: pointer;
  border: 0;
  background: transparent;
  font-size: 1em;
  text-decoration: underline;
  appearance: none;
}

this is needed so that the "Edit summary" button looks ok in create content form (and other forms )

[drishu]

Looks good, but one more hurdle to pass, the functionality of other patterns was affected because the fields and options changed, please fix:
pattern-collapse.html.twig
pattern-dropdown.html.twig
pattern-modal.html.twig
pattern-popover.html.twig

[Maxfire]

Looks good, but one more hurdle to pass, the functionality of other patterns was affected because the fields and options changed, please fix:
pattern-collapse.html.twig
pattern-dropdown.html.twig
pattern-modal.html.twig
pattern-popover.html.twig

I checked all and collapse was fixed, also checked different variants, greetings.

[drishu]

intendation is not correct, and there is a extra space

Suggested change

	}) %}
	}) %}

[drishu]

• Button pattern.

[drishu]

in the login form, the class button--primary is not set for the login button, it seems that this class is added per use case and not automatically by a rule.
To solve this issue, we can do something like {% elseif attributes['data-drupal-selector'] == 'edit-submit' %}

[Maxfire]

Ok I'm going to add it as or condition in the same if. thanks.

[drishu]

Suggested change

	{% if _icon %}
	{% if icon %}

[drishu]

the icon is to close to the text, please add attributes: create_attribute().addClass('me-1'), like in netlify data tab

[drishu]

url doesn't exist

[drishu]

Suggested change

	style: style,
	variant: style,

[Maxfire]

this could be a bit confusing but ok.