FRONT-2478: List group pattern. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escuriola
changed the title
GilNovacomm
reviewed
Aug 30, 2021
There was a problem hiding this comment.
While the pattern works as designed a few points should be reviewed:
The border around the component is missing.
Passing items to the pattern itself does not work so a pattern override template for this component needs to be implemented to preprocess the necessary variables.
There is no List group paragraph, Listing item block is an existing paragraph if the later is the one this pattern is supposed to theme then it's name it not obvious and should be corrected.
drishu
requested changes
Sep 22, 2021
| horizontal: | ||
| type: boolean |
There was a problem hiding this comment.
must be select and list the options
escuriola
force-pushed
the
FRONT-2478
branch
from
6ac4a3f
to
e0b2f02
Compare
drishu
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.