FRONT-2483: Progress pattern. #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drishu
requested changes
Aug 30, 2021
abel-santos-corral
force-pushed
the
FRONT-2483
branch
2 times, most recently
from
487ebb1
to
1a8700d
Compare
claudiu-cristea
force-pushed
the
FRONT-2483
branch
from
36b3c1c
to
9b34b62
Compare
escuriola
force-pushed
the
FRONT-2483
branch
2 times, most recently
from
5983146
to
348e5ae
Compare
claudiu-cristea
force-pushed
the
FRONT-2483
branch
from
348e5ae
to
1a8045d
Compare
drishu
force-pushed
the
FRONT-2483
branch
3 times, most recently
from
bc98af7
to
c7902bf
Compare
drishu
requested changes
Oct 5, 2021
| message: | ||
| type: "text" | ||
| label: "Optional description text below the progress bar" | ||
| min: |
There was a problem hiding this comment.
Please check, min should be moved to settings part.
There was a problem hiding this comment.
Min and Max are fields due to free text is not allowed on the settings section and at alexis branch this were also fields, not settings.
| type: "text" | ||
| label: "Minimum state of prorgress bar" | ||
| preview: "0" | ||
| max: |
There was a problem hiding this comment.
Same for max, should be placed at settings.
abel-santos-corral
previously approved these changes
Oct 11, 2021
drishu
previously approved these changes
Oct 11, 2021
…en component progress-bar.html.twig.
drishu
dismissed stale reviews from abel-santos-corral and themself
via
a6c0885
drishu
approved these changes
Oct 11, 2021
abel-santos-corral
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.