Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FRONT-2486: Popover pattern. #57

Merged
merged 22 commits into from
Sep 24, 2021
Merged

FRONT-2486: Popover pattern. #57

merged 22 commits into from
Sep 24, 2021

Conversation

escuriola
Copy link
Contributor

No description provided.

@abel-santos-corral abel-santos-corral linked an issue Aug 25, 2021 that may be closed by this pull request
@Maxfire Maxfire force-pushed the FRONT-2486 branch 2 times, most recently from c3969ba to 9619a82 Compare September 6, 2021 13:25
Maxfire
Maxfire previously approved these changes Sep 6, 2021
Copy link
Contributor

@Maxfire Maxfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and it worked nicely. 👍

templates/patterns/popover/pattern-popover.html.twig Outdated Show resolved Hide resolved
templates/patterns/popover/popover.js Outdated Show resolved Hide resolved
templates/patterns/popover/popover.js Outdated Show resolved Hide resolved
templates/patterns/popover/popover.js Outdated Show resolved Hide resolved
@drishu drishu merged commit 74f0b70 into 1.x Sep 24, 2021
@drishu drishu deleted the FRONT-2486 branch September 24, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Popover pattern with BCL component
4 participants