EWPP-131: Fix broken settings submit. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
previously approved these changes
Nov 23, 2020
ademarco
requested changes
Nov 23, 2020
oe_corporate_site_info.module
Outdated
| $form['#submit'] = ['_oe_corporate_site_info_settings_form_submit']; | ||
| // SiteInformationForm:submitForm calls the parent :submitForm, | ||
| // so we need to add our submit function to the beginning of the list | ||
| // to give it a change to execute. |
There was a problem hiding this comment.
Suggested change
| // to give it a change to execute. | |
| // to give it a chance to execute. |
oe_corporate_site_info.module
Outdated
| @@ -79,7 +79,10 @@ function oe_corporate_site_info_form_system_site_information_settings_alter(&$fo | |||
| '#description' => t('This is not the writer of the content, but the subject matter expert responsible for keeping this content up to date. <br>When this field is populated, it will provide the default Content owner for all new content on this website. It can be overwritten for every new item.'), | |||
| ]; | |||
|
|
|||
| $form['#submit'] = ['_oe_corporate_site_info_settings_form_submit']; | |||
| // SiteInformationForm:submitForm calls the parent :submitForm, | |||
There was a problem hiding this comment.
Suggested change
| // SiteInformationForm:submitForm calls the parent :submitForm, | |
| // SiteInformationForm::submitForm calls the parent ::submitForm, |
ademarco
approved these changes
Nov 23, 2020
22Alexandra
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add our submit function to the beginning of the list to give it a change to execute.