[Contribution] DARWIN-1045: Provide link to user profile and/or subscriptions page #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGilMartinez
changed the title
donquixote
reviewed
May 15, 2024
Comment on lines
+40
to
+44
| if ( | ||
| $type == 'oe_subscriptions_anonymous' && | ||
| isset($tokens['subscriptions_page']) && | ||
| !empty($data['message']) | ||
| ) { |
There was a problem hiding this comment.
I like this formatting better:
Suggested change
| if ( | |
| $type == 'oe_subscriptions_anonymous' && | |
| isset($tokens['subscriptions_page']) && | |
| !empty($data['message']) | |
| ) { | |
| if ($type === 'oe_subscriptions_anonymous' | |
| && isset($tokens['subscriptions_page']) | |
| && !empty($data['message']) | |
| ) { |
Actually, Drupal core is inconsistent about this.
And in /vendor/ you also find different formats.
See
https://www.drupal.org/project/coding_standards/issues/3392321
https://www.drupal.org/project/coding_standards/issues/1539712
Look for "&&" to find relevant comments.
Ultimately you can decide this with the OEL team.
donquixote
reviewed
May 15, 2024
| @@ -50,7 +63,8 @@ public function testLinkTemplate(): void { | |||
| '', | |||
| [ | |||
| 'href' => $front_url->toString(), | |||
| ] | |||
| ], | |||
| $template_name | |||
There was a problem hiding this comment.
Multi line argument list should have comma after the last item.
I thought this would be in automatic code style checks but seems it is not?
AaronGilMartinez
force-pushed
the
contribution/DARWIN-1045
branch
from
7f5633a
to
74e66fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.