OPENEUROPA-1744: Implement site switcher in oe_theme. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
changed the title
voidtek
requested changes
Apr 1, 2019
tests/Kernel/CorporateBlocks/CorporateBlocksSiteSwitcherTest.php
Outdated
Show resolved
Hide resolved
templates/navigation/oe-corporate-blocks-site-switcher.html.twig
Outdated
Show resolved
Hide resolved
sergepavle
force-pushed
the
OPENEUROPA-1744
branch
2 times, most recently
from
0461b76
to
511c0da
Compare
voidtek
previously approved these changes
Apr 2, 2019
There was a problem hiding this comment.
It works like a charm. Good job @sergepavle. I approve it.
Can you update the description of the PR with the changelog paragraph?
…ocks. Extend rendering test.
sergepavle
force-pushed
the
OPENEUROPA-1744
branch
from
511c0da
to
e28a1af
Compare
upchuk
requested changes
Apr 3, 2019
tests/Kernel/CorporateBlocks/CorporateBlocksSiteSwitcherTest.php
Outdated
Show resolved
Hide resolved
upchuk
approved these changes
Apr 3, 2019
voidtek
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1744
Description
Style the site switcher block to the oe_theme using the related ECL component.
Assert the rendering through tests.
Change log
Commands