Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to invoke via async route #1

Closed
alexellis opened this issue Dec 17, 2018 · 7 comments · Fixed by #23
Closed

Add option to invoke via async route #1

alexellis opened this issue Dec 17, 2018 · 7 comments · Fixed by #23
Assignees

Comments

@alexellis
Copy link
Member

As a user I would like to consume events from a queue and then have them processed by my existing asynchronous queue workers over NATS Streaming so that I can have one single way to process all events and asynchronous code.

@daikeren
Copy link

@alexellis What's your preferred way of supporting async function? One possible solution might be add another annotation to function (maybe something like async: true ?)

Is there any suggestion?

@alexellis
Copy link
Member Author

cc @martindekov @tessellator

@daikeren I think async_invoke as an env-var would work.

@martindekov
Copy link

Derek assign: me

@martindekov
Copy link

I will try to implement this as soon as I can this time this week and will ping 👍

@alexellis
Copy link
Member Author

Can you check the PR #27 please?

@martindekov
Copy link

Should I augment this PR to be optional the asynchronous or adding call to the asynchronous gateway path to the connector SDK?

@martindekov
Copy link

martindekov commented Jun 10, 2019

I was thinking of two approaches, amend the asynchronous path to where we configure the gateway URL so now its http://your.ip:port it would become http://your.ip:port/async-function/http://your.ip:port/function/ this would be the easiest approach, the second approach would be to add some sort boolean to the ControllerConfig(I need to make sure thats the most appropriate place). The former would just re-vendor the SDK with this simple change %s/function/%s -> %s/%s and add logic to the implementations of the connector which will build the gateway URL with async/non-async path appended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants