Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance on Rebuild and Upstream timers #45

Closed
3 tasks done
embano1 opened this issue Dec 2, 2019 · 2 comments
Closed
3 tasks done

Provide guidance on Rebuild and Upstream timers #45

embano1 opened this issue Dec 2, 2019 · 2 comments

Comments

@embano1
Copy link
Contributor

embano1 commented Dec 2, 2019

My actions before raising this issue

For controller authors it would be nice to provide some guidance on sensible defaults for RebuildInterval and UpstreamTimeout. Currently, if none if these are provided it's unclear what the defaults are (in the case of UpstreamTimeout there is no timeout at all which could cause blocking issues during network/API problems).

Expected Behaviour

Provide guidance (docs) on sensible defaults or check provided values (empty) in the code and enforce timeouts respectively.

Current Behaviour

If neither of these intervals/timeouts are specified the behavior of the connector using the SDK is undetermined, especially in cases of network/API interruptions.

Possible Solution

  • Update docs
  • Enforce timeouts in code
@alexellis
Copy link
Member

Sounds good to me, can you suggest where to do this? The README / tester app are the two places I can think of.

@embano1
Copy link
Contributor Author

embano1 commented Dec 2, 2019

Yep, those two please :)

@embano1 embano1 closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants