Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faas-cli remove doesn't allow overriding gateway specified in file #267

Closed
dvdmuckle opened this issue Dec 26, 2017 · 3 comments · Fixed by #268
Closed

faas-cli remove doesn't allow overriding gateway specified in file #267

dvdmuckle opened this issue Dec 26, 2017 · 3 comments · Fixed by #268

Comments

@dvdmuckle
Copy link

Expected Behaviour

Using faas-cli remove should behave the same way as faas-cli deploy such that --gateway will override any gateway entry in the -f file.

Current Behaviour

Currently using faas-cli -f somefile.yaml --gateway http://somegateway.local:8080 will ignore the --gateway and instead try to use the gateway specified in the file provided.

Possible Solution

I'l look through the code and submit a PR request if I find the error, though it's worth mentioning the order of the flags doesn't seem to matter, the behavior is the same.

Steps to Reproduce (for bugs)

See above.

Context

Instead of using -f to specify functions to remove, I specify them by name. It's not that big of a deal, however remove should ideally mirror the function of deploy, except performing the opposite action.

Your Environment

  • Docker version docker version (e.g. Docker 17.0.05 ): 17.0.05-ce

  • Are you using Docker Swarm or Kubernetes (FaaS-netes)? Kubernetes, version 1.9.0

  • Operating System and version (e.g. Linux, Windows, MacOS): HypriotOS v7 (Modified Raspbian Jessie)

@alexellis
Copy link
Member

Hi thank you for raising this issue. Please see #268 from Stefan. Also would you like to join our Slack community? We'd like to have you join us there 👍 If so email alex@openfaas.com

@dvdmuckle
Copy link
Author

Wow, that was a lot of activity overnight! Expect an email from me about the Slack community!

@alexellis
Copy link
Member

No probs, glad to have you in the community 👍 please raise issues / generate discussion again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants