Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade project to latest gorilla mux package 1.6.2 #945

Closed
LucasRoesler opened this issue Nov 3, 2018 · 1 comment
Closed

Upgrade project to latest gorilla mux package 1.6.2 #945

LucasRoesler opened this issue Nov 3, 2018 · 1 comment

Comments

@LucasRoesler
Copy link
Member

We should upgrade to the newest gorilla mux release 1.6.2

The newest version primarily introduces first class middleware support. We may or may not want to use these. Most importantly it introduces some nice testing utilities that will make expanding the test coverage much easier.

Expected Work

In the spirt of semver, this should be a safe change since we only use gorilla for the mux and the mux behavior is well tested upstream. We will need to bump the version info in the Gopkg.toml, update the vendor, and then we can quickly verify that the required routes exist by browsing the UI and using the CLI to deploy/remove some functions.

@alexellis
Copy link
Member

Derek close: released

@derek derek bot closed this as completed Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants