You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
stack.yml can have multiple functions. If any one of the function has status failure, the overall status should be failure
This is ensured by github:
github status allow to specify user defined context
Status:
"state": "success",
"target_url": "status page",
"description": "The function has deployed as: user-function_name",
"context": "function_name"
In Github status if one context status is failure the whole status is failure
Additionally, a combined state is returned. The state is one of:
failure if any of the contexts report as error or failure
pending if there are no statuses or a context is pending
success if the latest status for all contexts is success
Possible Implementation:
We can get function specific status in the github status by specifying the context as function-name.
Once the yaml is parsed in git-tar the function status need to be shown as pending
and once buildshiprun as successfully deployed the function it need to be shown as success
if any error occurs the status should be failure
i.e. for a stack which include function-1 and function-2
the status will be updated as:
// For pending
Status: pending
function-1: pending
function-2: pending
// For one pending
Status: pending
function-1: success
function-2: pending
// For success
Status: success
function-1: success
function-2: success
// For failure
Status: failure
function-1: failure
function-2: success
Deal with error before the yaml is parsed:
Error might happen before the stack.yml is even parsed, for example stack.yml is not present. We need another separate context before even stack.yml is parsed
We can have a context named Stack Deploy. Stack Deploy status can be shown as pending as soon as a push event is accepted in gh-push Stack Deploy status can be success once the yaml is parsed Stack Deploy is failure in case of any error in between
i.e. for a stack which include function-1 and function-2
the status will be updated as:
Stack Deploy (Pending)
Stack Deploy (Failed)
Stack Deploy Passed, Function (Pending)
Stack Deploy Passed, Function (Failed
)
Stack Deploy Passed, One Function (Pending) One (success)
Stack Deploy Passed, One Function (Pending) One (failed)
Stack Deploy Passed, Both Function passed
The text was updated successfully, but these errors were encountered:
s8sg
changed the title
suggestion: Use separate Github status context for each function
suggestion (status): Use separate Github status context for each function
May 2, 2018
stack.yml
can have multiplefunction
s. If any one of the function has statusfailure
, the overall status should befailure
This is ensured by github:
github status allow to specify user defined
context
In Github status if one
context
status isfailure
the whole status isfailure
Please check here for more details
Possible Implementation:
We can get function specific status in the
github status
by specifying thecontext
asfunction-name
.Once the
yaml
is parsed ingit-tar
thefunction
status need to be shown aspending
and once
buildshiprun
as successfully deployed the function it need to be shown assuccess
if any error occurs the status should be
failure
i.e. for a stack which include
function-1
andfunction-2
the status will be updated as:
Deal with error before the yaml is parsed:
Error might happen before the
stack.yml
is even parsed, for examplestack.yml is not present
. We need another separate context before evenstack.yml
is parsedWe can have a context named
Stack Deploy
.Stack Deploy
status can be shown aspending
as soon as a push event is accepted ingh-push
Stack Deploy
status can besuccess
once the yaml is parsedStack Deploy
is failure in case of anyerror
in betweeni.e. for a stack which include
function-1
andfunction-2
the status will be updated as:
Stack Deploy (Pending)
Stack Deploy (Failed)
Stack Deploy Passed, Function (Pending)
Stack Deploy Passed, Function (Failed
)
Stack Deploy Passed, One Function (Pending) One (success)
Stack Deploy Passed, One Function (Pending) One (failed)
Stack Deploy Passed, Both Function passed
The text was updated successfully, but these errors were encountered: