Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump watchdog for GC optimisation #115

Closed
martindekov opened this issue Jan 11, 2019 · 4 comments
Closed

Bump watchdog for GC optimisation #115

martindekov opened this issue Jan 11, 2019 · 4 comments

Comments

@martindekov
Copy link

martindekov commented Jan 11, 2019

PR 1001 in the faas repo fixed a GC optimisation in the watchdog, but currently images are with older watchdog binary

Expected Behaviour

Pull watchdog binary with latest release (0.9.14)

Current Behaviour

Most of the templates are still with 0.9.6 release of the watchdog with the unoptimised GC

Possible Solution

In the templates which are using the classic watchdog change the Dockerfile to pull latest watchdog binary(0.9.14) here is example PR which updates the watchdog.

Steps to Reproduce (for bugs)

N.A. People use watchdog binary with memory leak unless they manually update their dockerfiles.

Context

The binary which is used now (0.9.6) for the Dockerfiles needs updating to the latest.

@martindekov
Copy link
Author

Derek add label: help wanted

@derek derek bot added the help wanted label Jan 11, 2019
@roncrivera
Copy link
Contributor

hi @martindekov i got this.

Ronald-Riveras-MacBook-Pro:templates ron$ find . -type f -name Dockerfile\* ! -path "./.git/*" -exec grep -H '/0.9.6' {} \;
./template/csharp/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./template/dockerfile/function/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./template/go/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./template/go-armhf/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./template/node/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./template/node-arm64/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-arm64 > /usr/bin/fwatchdog \
./template/node-armhf/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./template/php7/Dockerfile:    curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog && \
./template/python/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./template/python-armhf/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./template/python3/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \
./template/python3-armhf/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog-armhf > /usr/bin/fwatchdog \
./template/ruby/Dockerfile:    && curl -sSL https://github.com/openfaas/faas/releases/download/0.9.6/fwatchdog > /usr/bin/fwatchdog \

@alexellis alexellis changed the title Bump watchdog with memory leak issue fix Bump watchdog for GC optimisation Jan 12, 2019
@martindekov
Copy link
Author

Hello @roncrivera I approved your PR nice work !

@alexellis
Copy link
Member

Derek close: PR merged.

@derek derek bot closed this as completed Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants