Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP version update #267

Closed
1 of 2 tasks
Shikachuu opened this issue Aug 21, 2021 · 0 comments
Closed
1 of 2 tasks

PHP version update #267

Shikachuu opened this issue Aug 21, 2021 · 0 comments

Comments

@Shikachuu
Copy link
Contributor

The PHP version should be a supported one. (So at least PHP 7.3)

Expected Behaviour

The PHP version in the templates is at least PHP version 7.3.

Current Behaviour

The current version is 7.2 which is end-of-life and no longer supported/maintained.
https://www.php.net/supported-versions.php

Are you a GitHub Sponsor (Yes/No?)

Check at: https://github.com/sponsors/openfaas

  • Yes
  • No

List All Possible Solutions and Workarounds

  1. Update the PHP version to 7.3
  2. Update the PHP version to 7.4 (Merge my PR 😈 PHP version update #266)
  3. Remove the number from the PHP template, just call it php instead of php7 and migrate all the way up to PHP 8. (this is the most drastical, yet the best solution IMHO)

Which Solution Do You Recommend?

  1. Seems to be the easiest (since there is a PR for it), 3. would be the best.

Steps to Reproduce (for bugs)

  1. Create a functions with faas-cli with the --lang php7 flag.

Context

Create a PHP function with a secure and still maintained PHP version.

Your Environment

  • What Docker version are you using? Docker version 20.10.7, build f0df350

  • What version of Kubernetes are you using? none

  • Operating System and version (e.g. Linux, Windows, MacOS): Linux

  • Link to your project or a code example to reproduce issue: See Steps to Reproduce (for bugs)

@Shikachuu Shikachuu mentioned this issue Aug 21, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants