Some strain rosette cleanup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmokstad
force-pushed
the
strutils-cleanup
branch
from
fea3b0f
to
b56e8fe
Compare
calcPrincipalVals in the strainAndStressUtilitiesModule. Remove the use of ReportModuleModule for increased modularity. Add source code documentation in the strainAndStressUtils.f90 file.
Add some source code documentation in the strainRosetteModule.f90 file.
strainRosetteModule replacing similar subroutines in strainGageModule. The latter module is then no longer needed by the dynamics solver.
kmoks
force-pushed
the
strutils-cleanup
branch
3 times, most recently
from
3f4fefd
to
fe70cf1
Compare
initiateTriadAndSupElTypeModule and rename the latter to initiateStressModule. This module is then not needed by the solver.
kmokstad
force-pushed
the
strutils-cleanup
branch
from
fe70cf1
to
612a07a
Compare
Update CHANGELOG.md and README.md.
kmoks
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various unrelated refactoring and cleanup related to stress/gage recovery in the dynamics solver:
strainRosetteModuleincluding items fromstrainGageModulesuch that the latter is no longer needed by the dynamics solver.strainAndStressUtilitiesModuleremoving some dependencies and making it more modular.getFileName()subroutine by a common instance infileUtilitiesModule.initiateTriadAndSupelTypeModulebyinitiateStressModulealso including thereadSolverData()subroutine. This module is then not needed by dynamics solver.All the above is cosmetic fixes that should not affect the program logic or features. But since the submodule update involves a bugfix as well, the build counter is reset.