fix: wait for at least a successful migrate job run #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
previously approved these changes
May 2, 2024
rhamzeh
changed the title
rhamzeh
previously approved these changes
Jun 3, 2024
|
Thanks @tamalsaha! Can you please enable the "allow edits by maintainers" feature so we can update and merge? |
jon-whit
previously approved these changes
Jun 3, 2024
|
@tamalsaha please bump the |
Signed-off-by: Tamal Saha <tamal@appscode.com>
auto-merge was automatically disabled
June 3, 2024 22:19
Head branch was pushed to by a user without write access
tamalsaha
force-pushed
the
migreate-job-wr
branch
from
3e2dc6e
to
b4bc860
Compare
Signed-off-by: Tamal Saha <tamal@appscode.com>
|
Done. PTAL. |
tamalsaha
dismissed stale reviews from miparnisari, jon-whit, and rhamzeh
via
c6f7df4
jon-whit
approved these changes
Jun 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate job has backoff limit 1. Which means, it might fail once before succeeding (typically due to db not ready for connection). This pr allows such a scenario to be considered successful.
References
Review Checklist
main