Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra volumes to migrate job #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zach-Johnson
Copy link

This PR adds the extraVolumes and extraVolumeMounts to the migration job.

Description

I have a use case where I want to mount a CA cert bundle into the openfga deployment which is used
for the database connection.
It works fine for service, but the migration has no way that I can see to get the cert currently.
I think it is probably okay to re-use the existing vars for the volumes in the migrate job,
but I'm happy to move those to a separate value if that is preferable.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@Zach-Johnson Zach-Johnson requested review from a team as code owners June 19, 2024 23:58
@Zach-Johnson
Copy link
Author

Hey, any way to get a review on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant