Update modular-models.mdx #714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tightened up the tone, context, and tenses. QOL edits. Please contact me with any questions!
|
ewanharris
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Thanks for tidying this up @pavokta! Do you think the suggestions I made make sense?
|
|
||
| - A model can grow large and difficult to understand | ||
| - As more teams begin to contribute to a model, the ownership boundaries may not be clear and code review processes might not scale | ||
| As authorization models grow larger and more difficult to understand as more teams contribute to a model. As a result, model ownership boundaries may not be clear and code review processes might not scale. |
There was a problem hiding this comment.
Maybe a lead in to this might help?
Suggested change
| As authorization models grow larger and more difficult to understand as more teams contribute to a model. As a result, model ownership boundaries may not be clear and code review processes might not scale. | |
| As adoption of <ProductName format={ProductNameFormat.ShortForm}/> increases, authorization models can grow larger and more difficult to understand. As a result, model ownership boundaries may not be clear and code review processes might not scale. |
|
|
||
| ### Type Extensions | ||
|
|
||
| As teams implement features, they might find that core types they are dependent upon might not contain all the realtions they need. However, it might not make sense for these relations to be owned by the owner of that type if they aren't needed across the system. | ||
| In some cases, core module types that admin teams depend on might not contain all the relations they need. However, if those module types aren't needed across the system, it doesn't make sense for those relations to be owned by that type's owner. |
There was a problem hiding this comment.
I think admin might not be needed here
Suggested change
| In some cases, core module types that admin teams depend on might not contain all the relations they need. However, if those module types aren't needed across the system, it doesn't make sense for those relations to be owned by that type's owner. | |
| In some cases, core module types that teams depend on might not contain all the relations they need. However, if those module types aren't needed across the system, it doesn't make sense for those relations to be owned by that type's owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tightened up the tone, context, and tenses. QOL edits. Please contact me with any questions!
Description
References
Review Checklist
main