Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect build instruction in README.md #352

Closed
adriantam opened this issue Nov 18, 2022 · 0 comments · Fixed by #353
Closed

Incorrect build instruction in README.md #352

adriantam opened this issue Nov 18, 2022 · 0 comments · Fixed by #353
Assignees
@adriantam
Labels
bug Something isn't working

Comments

@adriantam
Copy link
Member

adriantam commented Nov 18, 2022 •
edited

The current README suggests that building openfga involves

go build cmd/openfga/openfga.go

However, there is no cmd/openfga/openfga.go. Instead, it is cmd/openfga/main.go

Instead of asking user to run go build, we can ask them to run make build for which we already configure the filename and output binary name.
@adriantam adriantam added the bug Something isn't working label Nov 18, 2022
@adriantam adriantam self-assigned this Nov 18, 2022
adriantam added a commit that referenced this issue Nov 18, 2022
@adriantam
fix: update README for build instruction
7b842ae 
Close #352
@adriantam adriantam mentioned this issue Nov 18, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriantam adriantam

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update README for build instruction openfga/openfga
1 participant
@adriantam