Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable conditions by default #1220

Merged
merged 3 commits into from
Dec 8, 2023
Merged

feat: enable conditions by default #1220

merged 3 commits into from
Dec 8, 2023

Conversation

jpadilla
Copy link
Member

@jpadilla jpadilla commented Dec 8, 2023

Description

In preparation for v1.4.0, we're enabling support for ABAC Conditional Relationships by default.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jpadilla jpadilla marked this pull request as ready for review December 8, 2023 17:32
@jpadilla jpadilla requested a review from a team as a code owner December 8, 2023 17:32
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f53b9d5) 82.38% compared to head (27d5fab) 82.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
- Coverage   82.38%   82.23%   -0.14%     
==========================================
  Files          83       83              
  Lines        9587     9555      -32     
==========================================
- Hits         7897     7857      -40     
- Misses       1338     1344       +6     
- Partials      352      354       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpadilla jpadilla merged commit c01b461 into main Dec 8, 2023
13 of 14 checks passed
@jpadilla jpadilla deleted the enable-conditions branch December 8, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants