Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #935 (log request validation errors) #1236

Merged
merged 5 commits into from
Dec 15, 2023
Merged

fix: #935 (log request validation errors) #1236

merged 5 commits into from
Dec 15, 2023

Conversation

miparnisari
Copy link
Member

@miparnisari miparnisari commented Dec 14, 2023

Description

Close #918 and #935

Now, all unary requests that are invalid (for example, a missing parameter) will be logged in the server.

Testing

With the tests in this PR + manual tests:

Logs in Main vs this PR:

image

Traces in this PR:

image

Response headers in this PR

image

@miparnisari miparnisari marked this pull request as ready for review December 14, 2023 22:55
@miparnisari miparnisari requested a review from a team as a code owner December 14, 2023 22:55
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d706e2c) 82.28% compared to head (7fd051a) 82.43%.

Files Patch % Lines
pkg/middleware/logging/logging.go 90.91% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
+ Coverage   82.28%   82.43%   +0.15%     
==========================================
  Files          83       83              
  Lines        9587     9588       +1     
==========================================
+ Hits         7888     7903      +15     
+ Misses       1344     1335       -9     
+ Partials      355      350       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jpadilla
jpadilla previously approved these changes Dec 15, 2023
cmd/run/run.go Outdated Show resolved Hide resolved
@miparnisari miparnisari merged commit 073c82f into main Dec 15, 2023
13 of 14 checks passed
@miparnisari miparnisari deleted the issue-935 branch December 15, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test that asserts request logging
2 participants