-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cancellation/timeouts on condition evaluation #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpadilla
force-pushed
the
condition-eval-with-context
branch
from
December 15, 2023 17:29
8688d9c
to
aabec48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
- Coverage 82.70% 82.67% -0.02%
==========================================
Files 84 84
Lines 9746 9749 +3
==========================================
Hits 8059 8059
- Misses 1332 1334 +2
- Partials 355 356 +1 ☔ View full report in Codecov by Sentry. |
jpadilla
force-pushed
the
condition-eval-with-context
branch
from
December 15, 2023 17:33
8da5626
to
1556af9
Compare
jon-whit
reviewed
Dec 15, 2023
miparnisari
reviewed
Dec 15, 2023
jpadilla
force-pushed
the
condition-eval-with-context
branch
from
December 20, 2023 19:00
37b558c
to
aa117f1
Compare
jpadilla
force-pushed
the
condition-eval-with-context
branch
from
December 20, 2023 20:06
cdbad72
to
b449bcb
Compare
jon-whit
reviewed
Dec 20, 2023
jon-whit
reviewed
Dec 20, 2023
jon-whit
reviewed
Dec 20, 2023
Co-authored-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
miparnisari
approved these changes
Jan 3, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ContextEval
instead ofEval
https://pkg.go.dev/github.com/google/cel-go/cel#Program.ContextEvalInterruptCheckFrequency
https://pkg.go.dev/github.com/google/cel-go/cel#InterruptCheckFrequencyIn aa117f1, I added two temporary benchmark suites to get an idea of how long evaluations might take based on the expression + parameters supplied. Notice the
p99(ns)
column.References
Review Checklist
main