-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve exclusion more deterministically in Check resolution #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-whit
commented
Dec 15, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 82.64% 82.64% +0.01%
==========================================
Files 84 84
Lines 9736 9746 +10
==========================================
+ Hits 8045 8054 +9
- Misses 1334 1336 +2
+ Partials 357 356 -1 ☔ View full report in Codecov by Sentry. |
miparnisari
requested changes
Dec 15, 2023
miparnisari
reviewed
Dec 15, 2023
miparnisari
reviewed
Dec 21, 2023
We have these same tests as unit tests elsewhere and it's hard to produce the non-determinism with a single test.
sergiught
reviewed
Jan 2, 2024
miparnisari
requested changes
Jan 2, 2024
miparnisari
reviewed
Jan 3, 2024
miparnisari
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve non-deterministic resolution of Check queries with relations involving exclusion.
Given a definition
a but not b
and concurrent resolution of both branchesa
andb
, then the following should occur:a
resolves to an{allowed: false}
outcome we should short-circuit and return. No further resolution ofb
is necessary.b
resolves to an{allowed: true}
outcome we should short-circuit and return. No further resolution ofa
is necessary.a
returns an error first, we must wait forb
to resolve, because ifb
resolves to{allowed: true}
the outcome should be{allowed: false}
, because we can resolve this with a deterministic outcome.b
returns an error first, we must wait fora
to resolve, because ofa
resolves to{allowed: false}
the outcome should be{allowed: false}
, because we can resolve this with a deterministic outcome.References
Closes #1238
Review Checklist
main