feat: new server.Stop() to close all server resources #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
commented
Jan 24, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
+ Coverage 82.65% 82.69% +0.04%
==========================================
Files 84 84
Lines 9768 9775 +7
==========================================
+ Hits 8073 8082 +9
+ Misses 1340 1338 -2
Partials 355 355 ☔ View full report in Codecov by Sentry. |
jon-whit
reviewed
Jan 24, 2024
miparnisari
changed the title
miparnisari
force-pushed
the
graceful-server-stop
branch
from
82d4b01
to
a8445fe
Compare
jon-whit
reviewed
Jan 24, 2024
jon-whit
reviewed
Jan 24, 2024
jon-whit
approved these changes
Jan 24, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1317.
Whether we use OpenFGA as a library or as a server, we need to provide an API to clean up Server resources.