Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update grpc-health-probe #1321

Merged
merged 1 commit into from
Jan 29, 2024
Merged

chore: update grpc-health-probe #1321

merged 1 commit into from
Jan 29, 2024

Conversation

jpadilla
Copy link
Member

@jpadilla jpadilla commented Jan 29, 2024

Description

  • Update grpc-health-probe to v0.4.24
  • Fix incorrect path for grpc-health-probe in default healthcheck command.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jpadilla jpadilla requested a review from a team as a code owner January 29, 2024 15:09
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (908ac85) 82.64% compared to head (89e61c7) 82.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
+ Coverage   82.64%   82.67%   +0.04%     
==========================================
  Files          84       84              
  Lines        9764     9764              
==========================================
+ Hits         8068     8071       +3     
+ Misses       1340     1338       -2     
+ Partials      356      355       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@miparnisari miparnisari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in 41279ae

@miparnisari miparnisari merged commit 0590992 into main Jan 29, 2024
14 checks passed
@miparnisari miparnisari deleted the healthcheck branch January 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants