-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tracing + attributes to all resolvers #1331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-whit
reviewed
Feb 1, 2024
jon-whit
reviewed
Feb 1, 2024
jon-whit
reviewed
Feb 1, 2024
jon-whit
reviewed
Feb 1, 2024
Co-authored-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
Co-authored-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
Co-authored-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
jon-whit
reviewed
Feb 1, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1331 +/- ##
=========================================
+ Coverage 0 83.83% +83.83%
=========================================
Files 0 85 +85
Lines 0 9850 +9850
=========================================
+ Hits 0 8257 +8257
- Misses 0 1239 +1239
- Partials 0 354 +354 ☔ View full report in Codecov by Sentry. |
willvedd
commented
Feb 1, 2024
willvedd
commented
Feb 1, 2024
4 tasks
miparnisari
reviewed
Feb 2, 2024
miparnisari
reviewed
Feb 2, 2024
Co-authored-by: Maria Ines Parnisari <maria.inesparnisari@okta.com>
…into resolver-tracing
miparnisari
reviewed
Feb 5, 2024
miparnisari
previously approved these changes
Feb 5, 2024
…into resolver-tracing
miparnisari
approved these changes
Feb 5, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving observability of the check resolution process by adding tracing and an appropriate set of attributes for each resolver. Previously, only the local check resolver had tracing but now that we have three separate resolvers, it makes sense to observe those too.
Admittedly, the
resolver_type
attribute is not a best practice and should have been accomplished by the built-inpackage
attribute but that would have required a messy refactor.Demo:
Note: traces show that nested resolver delegation doesn't work as intended. Behavior currently depends if cached is enabled or not. This will be fixed in future PR. These are just to prove that traces are working.
Cache disabled:
Cache enabled:
References
Review Checklist
main