Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for presharedkey auth in the Playground #141

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

jon-whit
Copy link
Member

@jon-whit jon-whit commented Aug 1, 2022

Description

This wires up auth support in the Playground for OpenFGA servers setup with preshared key authentication.

References

#133

Review Checklist

  • I have added documentation for new/changed functionality in this PR or in openfga.dev
  • The correct base branch is being used, if not main

@jon-whit jon-whit requested a review from a team as a code owner August 1, 2022 19:09
@jon-whit
Copy link
Member Author

jon-whit commented Aug 1, 2022

@rhamzeh @matldupont looks like the preshared auth support in the embedded Playground works mostly (see attached video). The only hiccup is that fetching the predefined model from the default Playground store fails because the local auth key isn't appropriate for the hosted Playground.

Do you guys have some recommendations on how we should resolve that elegantly?

auth-playground.mov

@rhamzeh
Copy link
Member

rhamzeh commented Aug 2, 2022

The only hiccup is that fetching the predefined model from the default Playground store fails because the local auth key isn't appropriate for the hosted Playground.

Is that what's happening? Let's discuss this in an issue in that repo, because the local playground should not be talking to the hosted version.

Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error not related, should be fixed in Play/SDK repo

@codecov-commenter
Copy link

Codecov Report

Merging #141 (f1232a5) into main (b4c45a4) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   75.68%   75.57%   -0.12%     
==========================================
  Files          77       77              
  Lines        8494     8504      +10     
==========================================
- Hits         6429     6427       -2     
- Misses       1680     1691      +11     
- Partials      385      386       +1     
Impacted Files Coverage Δ
pkg/cmd/run.go 0.00% <0.00%> (ø)
server/commands/check.go 86.27% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c45a4...f1232a5. Read the comment docs.

@jon-whit jon-whit merged commit dc8bfcf into main Aug 2, 2022
@jon-whit jon-whit deleted the playground-auth branch August 2, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants