Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListUsers API #1433

Merged
merged 112 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
112 commits
Select commit Hold shift + click to select a range
f621e6b
Initial commit
willvedd Feb 27, 2024
fc75d74
Getting working mostly
willvedd Feb 27, 2024
5143b3a
getting tests to pass
willvedd Feb 29, 2024
accaef5
poc cont.
willvedd Mar 7, 2024
9107b87
Removing prints
willvedd Mar 7, 2024
d44c526
Importing branched openfga api import
willvedd Mar 7, 2024
2d99278
Merge branch 'main' of https://github.com/openfga/openfga into list-u…
willvedd Mar 8, 2024
5fd262b
New types
willvedd Mar 8, 2024
ee58425
test: add harness for ListUsers YAML tests (#1429)
miparnisari Mar 8, 2024
4059f87
Merge branch 'main' into list-users
willvedd Mar 13, 2024
b35c095
test: add more integration tests for ListUsers API (#1441)
miparnisari Mar 15, 2024
633db65
test: ListUsers unit tests (#1448)
willvedd Mar 18, 2024
c7c3f3c
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 18, 2024
5e6c3e6
User proto utility functions - converting to/from strings (#1463)
willvedd Mar 18, 2024
84a8ec8
ListUsers: remove duplicate results (#1457)
miparnisari Mar 19, 2024
e25b59f
fix(list-users): initialization of response array (#1470)
miparnisari Mar 19, 2024
9c7547e
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 20, 2024
56f66a3
`ListUsers` edge pruning (#1464)
willvedd Mar 20, 2024
41730e6
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 20, 2024
55b0f82
Fixing test
willvedd Mar 20, 2024
600fe9a
`ListUsers` intersection (#1467)
willvedd Mar 21, 2024
e7b069d
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 21, 2024
e510c68
listusers: avoid stack overflows (#1451)
miparnisari Mar 21, 2024
b29f566
`ListUsers` integration tests for intersection (#1471)
miparnisari Mar 22, 2024
40ec32f
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 25, 2024
8a5a0da
`ListUsers` temporarily skip failing tests as we develop (#1486)
willvedd Mar 25, 2024
98d8c6c
`ListUsers` exclusion (#1473)
willvedd Mar 25, 2024
095af1d
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 26, 2024
a64d088
`ListUsers` integration tests for exclusion (#1484)
miparnisari Mar 26, 2024
b68f815
Merging with upstream
willvedd Mar 26, 2024
c253b6b
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 26, 2024
5d273ab
Updating protobuf type version
willvedd Mar 26, 2024
f77a05e
`ListUsers` intersection with wildcards (#1485)
willvedd Mar 26, 2024
6b10636
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Mar 26, 2024
afdfb14
Fixing tests, unignorning already-fixed tests
willvedd Mar 26, 2024
92ec5b1
Unskipping test
willvedd Mar 27, 2024
25ccfc9
Merging with upstream
willvedd Apr 1, 2024
56ad41b
fix:`ListUsers` include correct relation when returning usersets (#1500)
willvedd Apr 3, 2024
0be2a16
Unskipping tests that are now fixed
willvedd Apr 5, 2024
4ccbac5
Wiring-up contextual tuples integration tests
willvedd Apr 5, 2024
0142415
fix: `ListUsers` experimental flag (#1525)
willvedd Apr 10, 2024
9ea3767
Adding experimental flag to integration test server
willvedd Apr 10, 2024
62a9c99
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Apr 10, 2024
a8ba788
fix: `ListUsers` API validation (#1516)
willvedd Apr 11, 2024
dcd3a9d
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Apr 12, 2024
348aba4
Fixing failing test
willvedd Apr 12, 2024
493a72c
fix: `ListUsers` reflexive usersets support (#1526)
willvedd Apr 16, 2024
b122178
Adding list-users to TestHTTPHeaders
willvedd Apr 16, 2024
fcc29a4
`ListUsers`: add tracing (#1539)
miparnisari Apr 17, 2024
aeb8407
fix: `ListUsers` recursive depth limit protection (#1532)
willvedd Apr 17, 2024
6ebe09d
test: Adding `ListUsers` case to TestReleasesConnections (#1545)
willvedd Apr 18, 2024
041b489
Unskipping integration test
willvedd Apr 19, 2024
d5ada2e
fix: `ListUsers` race conditions (#1551)
miparnisari Apr 19, 2024
64affd7
fix(list-users): goroutine leak (#1564)
miparnisari Apr 23, 2024
804f71c
Merge remote-tracking branch 'origin/main' into list-users
miparnisari Apr 23, 2024
acbe2d0
fix: `ListUsers` ABAC support via conditions (#1515)
willvedd Apr 24, 2024
0634e16
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Apr 25, 2024
dae5995
Merge branch 'main' of https://github.com/openfga/openfga into list-u…
willvedd Apr 25, 2024
40a3c09
Fixing linting issues
willvedd Apr 25, 2024
9b7ad7f
Updating with new protobuf definitions
willvedd Apr 25, 2024
c28b50c
Removing temporary test skips
willvedd Apr 25, 2024
c2fcca8
Removing unnecessary comments
willvedd Apr 25, 2024
568e89c
Merge branch 'main' into list-users
willvedd Apr 25, 2024
4954cd6
feat: add ListUsers configuration options (#1572)
miparnisari Apr 26, 2024
d630062
feat: `ListUsers` datastore query count (#1574)
willvedd Apr 26, 2024
8655dfa
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Apr 26, 2024
38d00a0
Updating with new protobuf definitions
willvedd Apr 26, 2024
f4e9de2
perf: add List users benchmark (#1555)
miparnisari Apr 26, 2024
9dd1d60
Adding test case for TestOperationsWithInvalidModel
willvedd Apr 29, 2024
3893b38
Addressing feedback
willvedd Apr 29, 2024
7187f36
Removing remaining TemporarilySkipReason code
willvedd Apr 29, 2024
73eae48
Fixing lint issues, DSQC test failures
willvedd Apr 29, 2024
bd4a40e
Fixing merge conflicts
willvedd Apr 29, 2024
e060855
fix(list-users): leaking goroutines due to blocked sending to channel…
miparnisari Apr 29, 2024
8c8da85
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Apr 29, 2024
a702e95
Removing unnecessary print
willvedd Apr 29, 2024
5970ce6
fix: `ListUsers` handling of cycles in exclusion handler (#1573)
willvedd Apr 30, 2024
c8a0113
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd Apr 30, 2024
c4953b8
Using latest version of proto definitions
willvedd Apr 30, 2024
767a7f6
Merge branch 'main' of https://github.com/openfga/openfga into list-u…
willvedd May 1, 2024
e4b081d
Merge branch 'main' of https://github.com/openfga/openfga into list-u…
willvedd May 1, 2024
257a482
fix(list-users): return partial results when deadline is met instead …
jon-whit May 1, 2024
b271bf6
fix: ListUsers config related to deadline settings (#1587)
jon-whit May 1, 2024
8e98c3d
Ensuring request validation if used as library
willvedd May 1, 2024
5a7d3c7
Fixing linting issues
willvedd May 1, 2024
4833f4e
Removing duplicate test case
willvedd May 3, 2024
e1534db
fix(list-users): send error before results (#1606)
miparnisari May 7, 2024
582aae3
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd May 10, 2024
e16b514
Fixing typo
willvedd May 10, 2024
c170551
feat(list-users): ListUsers with Excluded Users (#1604)
jon-whit May 20, 2024
073ff3a
feat(list-users): Implement dispatch count for list users (#1627)
poovamraj May 22, 2024
f85053e
Fixing type of dispatch channel
willvedd May 22, 2024
49f8687
Merging with main
willvedd May 22, 2024
d4d4d39
Merging with main
willvedd May 22, 2024
f38ad0e
Fixing test
willvedd May 22, 2024
313d078
Undoing extraneous changes
willvedd May 22, 2024
90d2c5b
Removing old parser
willvedd May 22, 2024
a3da542
Addressing PR feedback
willvedd May 22, 2024
2721553
Fixing linting error
willvedd May 22, 2024
10ffdbc
Adding mock datastore closers
willvedd May 22, 2024
3a0a62c
Update internal/server/config/config.go
willvedd May 22, 2024
e7b1a2d
Addressing PR feedback
willvedd May 28, 2024
fa1026e
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd May 28, 2024
bb03001
Addressing PR feedback cont.
willvedd May 28, 2024
c1133ef
Merge branch 'main' of https://github.com/openfga/openfga into list-u…
willvedd May 28, 2024
bfb1e00
Fixing TestUserFiltersToString test
willvedd May 28, 2024
25c237f
Updating deps
willvedd May 29, 2024
f18c870
Adjusting benchmarks to be sligtly more probable to pass
willvedd May 29, 2024
d994904
chore: avoid setting trace error on 4xx series error codes
jon-whit May 29, 2024
f2f5252
Removing unnecessary logic
willvedd May 29, 2024
b7086b1
Merge branch 'list-users' of https://github.com/openfga/openfga into …
willvedd May 29, 2024
45dca6f
Revert "Updating deps"
willvedd May 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .config-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
"default": 4294967295,
"x-env-variable": "OPENFGA_MAX_CONCURRENT_READS_FOR_LIST_OBJECTS"
},
"maxConcurrentReadsForListUsers": {
"description": "The maximum allowed number of concurrent reads in a single ListUsers query (default is MaxUint32).",
"type": "integer",
"default": 4294967295,
"x-env-variable": "OPENFGA_MAX_CONCURRENT_READS_FOR_LIST_USERS"
},
"changelogHorizonOffset": {
"description": "The offset (in minutes) from the current time. Changes that occur after this offset will not be included in the response of ReadChanges.",
"type": "integer",
Expand Down Expand Up @@ -62,6 +68,20 @@
"default": 1000,
"x-env-variable": "OPENFGA_LIST_OBJECTS_MAX_RESULTS"
},
"listUsersDeadline": {
"description": "The timeout deadline for serving ListUsers requests. If 0s, there is no deadline",
"type": "string",
"format": "duration",
"default": "3s",
"x-env-variable": "OPENFGA_LIST_USERS_DEADLINE"
},
"listUsersMaxResults": {
"description": "The maximum results to return in ListUsers API response. If 0, all results can be returned",
"type": "integer",
"minimum": 0,
"default": 1000,
"x-env-variable": "OPENFGA_LIST_USERS_MAX_RESULTS"
},
"requestDurationDatastoreQueryCountBuckets": {
"description": "Datastore query count buckets used to label the histogram metric for measuring request duration.",
"type": "array",
Expand Down Expand Up @@ -89,7 +109,7 @@
"type": "array",
"items": {
"type": "string",
"enum": []
"enum": ["enable-list-users"]
},
"default": [],
"x-env-variable": "OPENFGA_EXPERIMENTALS"
Expand Down
Loading
Loading