Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListUsers integration tests for intersection #1471

Merged
merged 2 commits into from
Mar 22, 2024
Merged

ListUsers integration tests for intersection #1471

merged 2 commits into from
Mar 22, 2024

Conversation

miparnisari
Copy link
Member

Description

Add assertions for ListUsers API in models that contain intersection.

References

#1428

@miparnisari miparnisari changed the base branch from main to list-users March 20, 2024 01:30
@willvedd willvedd changed the title Initial commit ListUsers integration tests for intersection Mar 20, 2024
@miparnisari miparnisari force-pushed the add-integ-tests-for-intersection branch from b87ae2e to e273215 Compare March 20, 2024 18:40
@miparnisari miparnisari marked this pull request as ready for review March 20, 2024 23:04
@miparnisari miparnisari requested a review from a team as a code owner March 20, 2024 23:04
@miparnisari miparnisari force-pushed the add-integ-tests-for-intersection branch from e273215 to 807107b Compare March 21, 2024 00:31
@miparnisari miparnisari force-pushed the add-integ-tests-for-intersection branch from 807107b to 05c2e62 Compare March 21, 2024 15:34
willvedd
willvedd requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. My only request is that we add cases for relation_with_wildcard_involving_intersection? That's a pretty important one that's top-of-mind currently.

@miparnisari
Copy link
Member Author

My only request is that we add cases for relation_with_wildcard_involving_intersection? That's a pretty important one that's top-of-mind currently.

Do you mean add assertions? I pushed another one, but i can't think of any others 🤔

@miparnisari miparnisari merged commit b29f566 into list-users Mar 22, 2024
5 checks passed
@miparnisari miparnisari deleted the add-integ-tests-for-intersection branch March 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

@jon-whit jon-whit Awaiting requested review from jon-whit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miparnisari @willvedd