Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump grpc-health-probe in Goreleaser built image #1507

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

jon-whit
Copy link
Member

@jon-whit jon-whit commented Apr 2, 2024

Description

Resolve the differences between the Dockerfile and the one used in the Goreleaser build Dockerfile.goreleaser. See:

FROM ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.25@sha256:6cc1dc0af87b35db2ca5fa9b1fbbc389e7570d8ad90ff84a54b6f7ac35cdb423 as grpc_health_probe

vs
COPY --from=ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.24 /ko-app/grpc-health-probe /usr/local/bin/grpc_health_probe

References

Closes #1504 (see https://github.com/orgs/openfga/discussions/290)
goreleaser/goreleaser#4741

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jon-whit jon-whit requested a review from a team as a code owner April 2, 2024 22:46
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (f26528f) to head (291aaa0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   86.10%   86.04%   -0.06%     
==========================================
  Files          85       85              
  Lines        8046     8046              
==========================================
- Hits         6927     6922       -5     
- Misses        789      793       +4     
- Partials      330      331       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jon-whit
Copy link
Member Author

jon-whit commented Apr 2, 2024

Note: ideally we'd do the following:

FROM ghcr.io/grpc-ecosystem/grpc-health-probe:v0.4.5 as grpc_health_probe

FROM cgr.dev/chainguard/static:latest

COPY --from=grpc_health_probe /ko-app/grpc-health-probe /usr/local/bin/grpc_health_probe

COPY assets /assests
COPY openfga /

ENTRYPOINT ["/openfga"]

this way dependabot could notice the first image from the multi-stage build and we could get automatic updates. But goreleaser doesn't support multi-stage builds today and dependabot does not support automatic updates of inline image copies. So until one of these issues is resolved we're stuck with manual updates.

@rhamzeh
Copy link
Member

rhamzeh commented Apr 3, 2024

FOSSA is failing for some reason, retrying
Screenshot 2024-04-02 at 8 50 34 PM

@jpadilla jpadilla merged commit 6e60c44 into main Apr 3, 2024
15 checks passed
@jpadilla jpadilla deleted the bump-grpc-health-probe branch April 3, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc-health-probe in Dockerfile and in the published docker image are different
4 participants