Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove experimentals for modular models/schema 1.2 #1520

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

ewanharris
Copy link
Member

Description

Removes the experimental flag that was guarding the ability to write modular models/schema 1.2.

I've left in some of the tests just to exercise that the ability to write 1.2 is there but happy to remove if that's perferred.

References

Original PR #1443

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner April 9, 2024 17:32
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.08%. Comparing base (ab0d835) to head (9172176).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   86.07%   86.08%   +0.02%     
==========================================
  Files          85       85              
  Lines        8046     8038       -8     
==========================================
- Hits         6925     6919       -6     
+ Misses        790      789       -1     
+ Partials      331      330       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jon-whit
Copy link
Member

Merging despite the govulncheck report. Will follow up with that in a separate PR as it is unrelated.

@jon-whit jon-whit merged commit 48b5992 into main Apr 10, 2024
14 of 15 checks passed
@jon-whit jon-whit deleted the chore/remove-modular-models-experimental branch April 10, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants