-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: DSL indentation in tests inside pkg server #1620
Conversation
I see check on "Pull Request / test (pull_request)" has lots of errors that I can't replicate on my local while running Seems to be integration tests running while dependency (MySQL / GRPC) not ready. E.g.:
May I get any help/support to troubleshoot? |
85cfff9
to
f907195
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
+ Coverage 86.21% 86.26% +0.05%
==========================================
Files 90 90
Lines 8466 8466
==========================================
+ Hits 7298 7302 +4
+ Misses 825 823 -2
+ Partials 343 341 -2 ☔ View full report in Codecov by Sentry. |
TODO [for me]:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
==========================================
- Coverage 86.99% 86.21% -0.78%
==========================================
Files 95 90 -5
Lines 9328 8466 -862
==========================================
- Hits 8114 7298 -816
+ Misses 857 825 -32
+ Partials 357 343 -14 ☔ View full report in Codecov by Sentry. |
480fbd8
to
36048db
Compare
…pkg server Pushing 1 file at a time to try to trobleshot git test workflow error
…pkg server Pushing 1 file at a time to try to trobleshot git test workflow error
Pushing 1 file at a time to try to troubleshoot git test workflow error
Pushing 1 file at a time to try to troubleshoot git test workflow error
Pushing 1 file at a time to try to troubleshoot git test workflow error. Now going one function at a time to isolate source of error.
Pushing remaining test files of pkg server. There's a known issue with some flaky tests (see openfga#1401) that might make github workflow "pull requests / tests" fail
Can't reproduce locally, so pushing to draft PR to observe behavior
- installed go.uber.org/mock/mockgen@latest used by `make generate-mocks` - Aligned with current PR statsu, removed unused dependency on uuid. Pending confirmation on whether to use ULID or UUID
PR Update: use UUID (instead of ULID) for request_id when there's no trace_id
6eb469e
to
0103489
Compare
Fixes #1339 for package server
Description
Now that openfga/language parser has better support for whitespaces, refactor to
have better readability in the test files.
References
Issue #1302
Continuation of closed PR #1597
Review Checklist
main