fix: list objects to respect configurable ListObjectsDeadline #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriantam
force-pushed
the
fix/listobject_timeout
branch
from
060854c
to
456a627
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
==========================================
+ Coverage 77.99% 78.10% +0.12%
==========================================
Files 59 59
Lines 7030 7044 +14
==========================================
+ Hits 5482 5501 +19
+ Misses 1260 1257 -3
+ Partials 288 286 -2
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jon-whit
reviewed
Apr 21, 2023
jon-whit
reviewed
Apr 21, 2023
miparnisari
requested changes
Apr 21, 2023
adriantam
force-pushed
the
fix/listobject_timeout
branch
from
1d4252b
to
8b7f2e0
Compare
miparnisari
reviewed
Apr 24, 2023
miparnisari
reviewed
Apr 24, 2023
miparnisari
reviewed
Apr 24, 2023
List objects should return results when ListObjectsDeadline is hit rather than waiting for results to be completed. Otherwise, 500 internal error will be returned if the request takes a long time. Close #703
adriantam
force-pushed
the
fix/listobject_timeout
branch
from
8b7f2e0
to
f6a72e6
Compare
miparnisari
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
List objects should return results when ListObjectsDeadline is hit rather than waiting for results to be completed. Otherwise, 500 internal error will be returned if the request takes a long time (i.e., maybe due to many items to be looked up).
References
context deadline exceededfor list object withbut notrelationship under load #703Tests
Review Checklist
main