Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hoist configuration to top level #35

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Aug 1, 2023

Hoisted configuration files to extension top level for organization. Files do not need to be under client to be packaged or referenced.

Description

Moved up to top level for consistency with other LSP extensions;

  • syntax
  • themes
  • language-configuration.json

Also added LICENSE file

openfga-vscode-1.0.0.vsix.zip

References

Following are examples from vscode extension samples package

VSCode clients with language config / syntax / snippets at top level of package.

Counter example:

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery requested a review from rhamzeh August 1, 2023 03:25
@rhamzeh
Copy link
Member

rhamzeh commented Aug 1, 2023

consistency with other LSP extensions

Can you provide a link to those extensions or documentation about this?

@d-jeffery d-jeffery marked this pull request as ready for review August 1, 2023 15:43
@d-jeffery d-jeffery requested a review from a team as a code owner August 1, 2023 15:43
@rhamzeh rhamzeh changed the title chore: Hoist configuration to top level chore: hoist configuration to top level Aug 1, 2023
@rhamzeh rhamzeh merged commit 107dfc5 into main Aug 1, 2023
5 checks passed
@rhamzeh rhamzeh deleted the chore/file-cleanup branch August 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants