Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Webpack bundling #37

Merged
merged 6 commits into from
Aug 1, 2023
Merged

fix: Webpack bundling #37

merged 6 commits into from
Aug 1, 2023

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Aug 1, 2023 •
edited
Loading

  • Added webpack for official build bundle
  • Fallback to tsc for building testable code

Description

Add webpack to bundle extension code for production. Build trigger on vsce package and both bundles and minifies code.

Added npm: compile to build testable code from source. Was unable to find a way to do this with elegance via webpack.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery changed the title Fix/webpack bundling fix: Webpack bundling Aug 1, 2023
@d-jeffery d-jeffery requested a review from rhamzeh August 1, 2023 19:29
@d-jeffery d-jeffery marked this pull request as ready for review August 1, 2023 19:32
@d-jeffery d-jeffery requested a review from a team as a code owner August 1, 2023 19:32
@d-jeffery
Copy link
Contributor Author

Latest Build:
openfga-vscode-1.0.0.vsix.zip

adriantam
adriantam reviewed Aug 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
@adriantam adriantam merged commit 1ef5e5c into main Aug 1, 2023
5 checks passed
@adriantam adriantam deleted the fix/webpack-bundling branch August 1, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

@rhamzeh rhamzeh Awaiting requested review from rhamzeh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command dependencies not being included in builds
2 participants
@d-jeffery @adriantam