Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default values for input parameters in virtual functions #134

Closed
dsuponitskiy opened this issue Jul 19, 2022 · 2 comments
Closed
Assignees
Labels
cleanup Code cleanup

Comments

@dsuponitskiy
Copy link
Collaborator

example: MakeCKKSPackedPlaintext() in src/pke/include/cryptocontext.h
This may become an issue as the overriders of virtual functions do not acquire the default arguments from the base class declarations, and when the virtual function call is made, the default arguments are decided based on the static type of the object.

@dsuponitskiy dsuponitskiy added the cleanup Code cleanup label Jul 19, 2022
@dsuponitskiy dsuponitskiy self-assigned this Jul 19, 2022
@dsuponitskiy
Copy link
Collaborator Author

The following virtual functions have default values for input parameters:
EvalBootstrapSetup()
EvalSumRows()
EvalSumRowsKeyGen()
KeyGen()
MakeCKKSPackedPlaintext()
LevelReduce()
LevelReduceInPlace()
ModReduceInternal()
ModReduceInternalInPlace()
MultiAddEvalAutomorphismKeys()
MultiAddEvalKeys()
MultiAddEvalMultKeys()
MultiAddEvalSumKeys()
MultiAddPubKeys()
MultiEvalAtIndexKeyGen()
MultiEvalAutomorphismKeyGen()
MultiMultEvalKey()
MultipartyKeyGen()
PrecomputeCRTTables()
ReEncrypt()

@dsuponitskiy
Copy link
Collaborator Author

The work is done. All code changes are in the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup
Projects
None yet
Development

No branches or pull requests

1 participant